This paper presents a qualitative study of student teachers' school-based learning in a teacher education program for secondary school teachers in Hong Kong. Learning to teach is examined through the lens of a personal-professional conceptualisation of learning. An in-depth study of two cases of student teachers' professional learning is reported. Research methods used include interviewing, tape-recording supervisory meetings, field observation and document analysis. Through an inquiry into the individual's interaction with pre-training influences, the teacher education program and the teaching practice context in the two cases, this study extends our understanding of student teachers' professional learning in terms of the formation of the teaching self and the process of framing in the action and socio-professional contexts of teaching practice. [Copyright of Asia-Pacific Journal of Teacher Education is the property of Routledge. Full article may be available at the publisher's website: http://dx.doi.org/10.1080/13598660120114977]